CNTRLPLANE-3956: Make EnsureGlobalPullSecret e2e test informing by csrwng · Pull Request #9167 · openshift/hypershift

csrwng · 2026-07-29T16:18:52Z

Summary

Mark the v2 EnsureGlobalPullSecret test as Informing so failures are reported as skips instead of failing the suite
Remove the v1 EnsureGlobalPullSecret call from create_cluster_test.go since standard Go testing has no informing mechanism

Why

The EnsureGlobalPullSecret validation is flaky and causing frequent e2e failures across CI runs. This unblocks CI while the root cause is investigated.

Test plan

Verify v2 e2e suite compiles with go vet -tags e2ev2 ./test/e2e/v2/tests/
Verify v1 e2e suite compiles with go build ./test/e2e/...
Confirm EnsureGlobalPullSecret failures no longer block e2e suite results

Jira: https://redhat.atlassian.net/browse/CNTRLPLANE-3956

🤖 Generated with Claude Code

Summary by CodeRabbit

Tests
- Updated end-to-end test coverage for cluster creation by removing the global pull secret validation step.
- Classified the additional pull secret scenario as an informing test for clearer test reporting.

The EnsureGlobalPullSecret validation is flaky and causing frequent e2e failures. Mark the v2 test as Informing so failures are reported as skips rather than suite failures, and remove the v1 call entirely. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

openshift-merge-bot · 2026-07-29T16:18:54Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

openshift-ci-robot · 2026-07-29T16:18:56Z

@csrwng: This pull request references CNTRLPLANE-3956 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

Mark the v2 EnsureGlobalPullSecret test as Informing so failures are reported as skips instead of failing the suite

Remove the v1 EnsureGlobalPullSecret call from create_cluster_test.go since standard Go testing has no informing mechanism

Why

The EnsureGlobalPullSecret validation is flaky and causing frequent e2e failures across CI runs. This unblocks CI while the root cause is investigated.

Test plan

Verify v2 e2e suite compiles with go vet -tags e2ev2 ./test/e2e/v2/tests/

Verify v1 e2e suite compiles with go build ./test/e2e/...

Confirm EnsureGlobalPullSecret failures no longer block e2e suite results

Jira: https://redhat.atlassian.net/browse/CNTRLPLANE-3956

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-07-29T16:19:17Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: ac4d9b59-6113-4578-8a0c-2f1308a41cc8

📥 Commits

Reviewing files that changed from the base of the PR and between f0235c7 and 92116d8.

📒 Files selected for processing (2)

test/e2e/create_cluster_test.go
test/e2e/v2/tests/hosted_cluster_pull_secret_test.go

💤 Files with no reviewable changes (1)

test/e2e/create_cluster_test.go

📝 Walkthrough

Walkthrough

The cluster creation E2E test no longer calls EnsureGlobalPullSecret and proceeds directly to metrics forwarder validation. The hosted cluster pull-secret test marks the additional pull-secret creation step with the Ginkgo Informing label.

Suggested reviewers: cblecker

🚥 Pre-merge checks | ✅ 11

✅ Passed checks (11 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: making the EnsureGlobalPullSecret e2e test informing and adjusting the related v1/v2 test behavior.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Touched Ginkgo titles are static strings; the PR only adds Label("Informing") and removes a v1 call, with no dynamic interpolation in test names.
Test Structure And Quality	✅ Passed	The v2 test uses repo-standard Informing labeling, bounded Eventually waits, and DeferCleanup; removing the v1 check doesn’t introduce a test-quality issue.
Topology-Aware Scheduling Compatibility	✅ Passed	Only e2e tests changed; no manifests, operators, controllers, or scheduling constraints were modified.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Touched Ginkgo change only adds Informing label; removed call elsewhere. No hardcoded IPv4, IPv6-hostile URLs, or external connectivity found in changed test code.
No-Weak-Crypto	✅ Passed	Changed files only adjust e2e test plumbing; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons were added.
Container-Privileges	✅ Passed	Touched files are test-only, and no privileged/K8s security settings appear in the diff or inspected code.
No-Sensitive-Data-In-Logs	✅ Passed	No new logging was added in the diff; it only removes a v1 check and marks the v2 Ginkgo block Informing.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

codecov · 2026-07-29T16:27:20Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.69%. Comparing base (deb7a80) to head (92116d8).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9167      +/-   ##
==========================================
+ Coverage   44.63%   44.69%   +0.06%     
==========================================
  Files         775      775              
  Lines       97085    97085              
==========================================
+ Hits        43336    43395      +59     
+ Misses      50762    50699      -63     
- Partials     2987     2991       +4

see 5 files with indirect coverage changes

Flag	Coverage Δ
cmd-support	`38.41% <ø> (ø)`
cpo-hostedcontrolplane	`47.23% <ø> (ø)`
cpo-other	`45.30% <ø> (ø)`
hypershift-operator	`54.59% <ø> (ø)`
other	`33.89% <ø> (+0.58%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ironcladlou · 2026-07-29T16:44:03Z

/lgtm

openshift-merge-bot · 2026-07-29T16:44:21Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aks-4-22
/test e2e-aws-4-22
/test e2e-aks
/test e2e-aws
/test e2e-aws-upgrade-hypershift-operator
/test e2e-azure-v2-self-managed
/test e2e-kubevirt-aws-ovn-reduced
/test e2e-v2-aws
/test e2e-v2-gke
/test unit
/test verify

cwbotbot · 2026-07-29T18:50:03Z

Test Results

e2e-aws

Status: ✅ PASS
Started: 2026-07-29T16:45:05Z
View Job
View Job History

e2e-aks

Status: ✅ PASS
Started: 2026-07-29T16:45:02Z
View Job
View Job History

devguyio · 2026-07-29T21:01:46Z

/override ci/prow/e2e-aws-4-22 ci/prow/e2e-azure-v2-self-managed ci/prow/e2e-kubevirt-aws-ovn-reduced

openshift-ci · 2026-07-29T21:02:49Z

@devguyio: Overrode contexts on behalf of devguyio: ci/prow/e2e-aws-4-22, ci/prow/e2e-azure-v2-self-managed, ci/prow/e2e-kubevirt-aws-ovn-reduced

Details

In response to this:

/override ci/prow/e2e-aws-4-22 ci/prow/e2e-azure-v2-self-managed ci/prow/e2e-kubevirt-aws-ovn-reduced

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

devguyio · 2026-07-29T21:02:51Z

/verified by e2e tests

openshift-ci-robot · 2026-07-29T21:03:02Z

@devguyio: This PR has been marked as verified by e2e tests.

Details

In response to this:

/verified by e2e tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

devguyio · 2026-07-29T21:05:11Z

/override ci/prow/e2e-aws ci/prow/e2e-aks ci/prow/e2e-aws-4-22 ci/prow/e2e-aks-4-22 ci/prow/e2e-aws-upgrade-hypershift-operator ci/prow/e2e-v2-aws ci/prow/e2e-v2-gke

openshift-ci · 2026-07-29T21:06:23Z

@devguyio: Overrode contexts on behalf of devguyio: ci/prow/e2e-aks, ci/prow/e2e-aks-4-22, ci/prow/e2e-aws, ci/prow/e2e-aws-4-22, ci/prow/e2e-aws-upgrade-hypershift-operator, ci/prow/e2e-v2-aws, ci/prow/e2e-v2-gke

Details

In response to this:

/override ci/prow/e2e-aws ci/prow/e2e-aks ci/prow/e2e-aws-4-22 ci/prow/e2e-aks-4-22 ci/prow/e2e-aws-upgrade-hypershift-operator ci/prow/e2e-v2-aws ci/prow/e2e-v2-gke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2026-07-29T21:08:45Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, devguyio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [csrwng,devguyio]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2026-07-29T21:53:11Z

@csrwng: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 29, 2026

openshift-ci Bot added the do-not-merge/needs-area label Jul 29, 2026

openshift-ci Bot requested review from clebs and sdminonne July 29, 2026 16:28

openshift-ci Bot added area/testing Indicates the PR includes changes for e2e testing approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Jul 29, 2026

openshift-ci Bot assigned ironcladlou Jul 29, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2026

devguyio mentioned this pull request Jul 29, 2026

OCPBUGS-99783: fix(e2e): check pre-upgrade HO version for shared role support #8891

Merged

2 tasks

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jul 29, 2026

devguyio approved these changes Jul 29, 2026

View reviewed changes

openshift-ci Bot assigned devguyio Jul 29, 2026

openshift-merge-bot Bot merged commit c5c1b86 into openshift:main Jul 29, 2026
43 checks passed

Uh oh!

Conversation

csrwng commented Jul 29, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Why

Test plan

Summary by CodeRabbit

Uh oh!

openshift-merge-bot Bot commented Jul 29, 2026

Uh oh!

openshift-ci-robot commented Jul 29, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Why

Test plan

Uh oh!

coderabbitai Bot commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Uh oh!

codecov Bot commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ironcladlou commented Jul 29, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 29, 2026

Uh oh!

cwbotbot commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

e2e-aws

e2e-aks

Uh oh!

devguyio commented Jul 29, 2026

Uh oh!

openshift-ci Bot commented Jul 29, 2026

Uh oh!

devguyio commented Jul 29, 2026

Uh oh!

openshift-ci-robot commented Jul 29, 2026

Uh oh!

devguyio commented Jul 29, 2026

Uh oh!

openshift-ci Bot commented Jul 29, 2026

Uh oh!

openshift-ci Bot commented Jul 29, 2026

Uh oh!

openshift-ci Bot commented Jul 29, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

csrwng commented Jul 29, 2026 •

edited by coderabbitai Bot

Loading

openshift-ci-robot commented Jul 29, 2026 •

edited by openshift-ci Bot

Loading

coderabbitai Bot commented Jul 29, 2026 •

edited

Loading

codecov Bot commented Jul 29, 2026 •

edited

Loading

cwbotbot commented Jul 29, 2026 •

edited

Loading